Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depreciation warnings and install latest pip from pip #165

Merged
merged 2 commits into from
Jul 22, 2016
Merged

Fix depreciation warnings and install latest pip from pip #165

merged 2 commits into from
Jul 22, 2016

Conversation

cryptk
Copy link
Contributor

@cryptk cryptk commented Jul 22, 2016

Currently on a "clean" container, stackstorm fails to install when using the latest pip that ships with 14.04 (which is the "supported platform" according to stackstorm's docs). Ensuring that the latest pip is installed from pypi fixes this.

Additionally, This uses latest/present/absent rather than true/false to fix a few depreciation warnings.

There are also some puppet-lint fixes in there as well.

This PR supersedes PR #118 which does not have the fix for the depreciation warnings.

@coveralls
Copy link

coveralls commented Jul 22, 2016

Coverage Status

Coverage remained the same at 38.32% when pulling 1b54697 on cryptk:python_pip_dependency into 3e35c02 on StackStorm:master.

@DoriftoShoes DoriftoShoes merged commit f8dff41 into StackStorm:master Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants