Fix state change when workflow output fails rendering #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
+ Coverage 94.23% 94.24% +<.01%
==========================================
Files 38 38
Lines 2375 2379 +4
Branches 468 470 +2
==========================================
+ Hits 2238 2242 +4
Misses 79 79
Partials 58 58
Continue to review full report at Codecov.
|
blag
approved these changes
Nov 9, 2018
If a workflow is already expired, abandoned, or canceled and there are errors rendering workflow output, keep the workflow state as is and don't change it to failed.
Before an entry is appended, match for duplicate and ignore if there is a match.
m4dcoder
force-pushed
the
fix-workflow-output-on-error
branch
from
97dfc79
to
7dcc711
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a workflow is already expired, abandoned, or canceled and there are errors rendering workflow output, keep the workflow state as is and don't change it to failed.