Add more test cases to capture edge cases for ctx().get()

StackStorm · Apr 10, 2020 · c5ef955 · c5ef955
1 parent 6990e5d
commit c5ef955
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/orquesta/tests/unit/expressions/test_facade_jinja_ctx_by_function_arg.py b/orquesta/tests/unit/expressions/test_facade_jinja_ctx_by_function_arg.py
@@ -19,7 +19,12 @@
 class JinjaFacadeVariableExtractionTest(test_base.ExpressionFacadeEvaluatorTest):
 
     def test_empty_extraction(self):
-        expr = '{{ just_text and $not_a_var and notctx(foo) and notctx("bar") and notctx(\'fu\') }}'
+        expr = (
+            '{{ just_text and $not_a_var and '
+            'notctx(foo) and notctx("bar") and notctx(\'fu\') '
+            'ctx("foo\') and ctx(\'foo") and ctx(foo") and '
+            'ctx("foo) and ctx(foo\') and ctx(\'foo) }}'
+        )
 
         self.assertListEqual([], expr_base.extract_vars(expr))
 
@@ -124,7 +129,8 @@ def test_ignore_ctx_dict_funcs(self):
     def test_ignore_ctx_get_func_calls(self):
         expr = (
             '{{ctx().get(foo) and ctx().get(bar) and ctx().get("fu") and ctx().get(\'baz\') and '
-            'ctx().get(foo, "bar") and ctx().get("fu", "bar") and ctx().get(\'bar\', \'foo\') }}'
+            'ctx().get(foo, "bar") and ctx().get("fu", "bar") and ctx().get(\'bar\', \'foo\') and '
+            'ctx().get("foo\') and ctx().get(\'foo") and ctx().get("foo) and ctx().get(foo") }}'
         )
 
         expected_vars = []

diff --git a/orquesta/tests/unit/expressions/test_facade_yaql_ctx_by_function_arg.py b/orquesta/tests/unit/expressions/test_facade_yaql_ctx_by_function_arg.py
@@ -19,7 +19,12 @@
 class YAQLFacadeVariableExtractionTest(test_base.ExpressionFacadeEvaluatorTest):
 
     def test_empty_extraction(self):
-        expr = '<% just_text and $not_a_var and notctx(foo) and notctx("bar") and notctx(\'fu\') %>'
+        expr = (
+            '<% just_text and $not_a_var and '
+            'notctx(foo) and notctx("bar") and notctx(\'fu\') '
+            'ctx("foo\') and ctx(\'foo") and ctx(foo") and '
+            'ctx("foo) and ctx(foo\') and ctx(\'foo) %>'
+        )
 
         self.assertListEqual([], expr_base.extract_vars(expr))
 
@@ -121,7 +126,8 @@ def test_ignore_ctx_dict_funcs(self):
     def test_ignore_ctx_get_func_calls(self):
         expr = (
             '<%ctx().get(foo) and ctx().get(bar) and ctx().get("fu") and ctx().get(\'baz\') and '
-            'ctx().get(foo, "bar") and ctx().get("fu", "bar") and ctx().get(\'bar\', \'foo\') %>'
+            'ctx().get(foo, "bar") and ctx().get("fu", "bar") and ctx().get(\'bar\', \'foo\') and '
+            'ctx().get("foo\') and ctx().get(\'foo") and ctx().get("foo) and ctx().get(foo") %>'
         )
 
         expected_vars = []