Changed webui smoke test to simply use localhost #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous variable resulted in a hostname that was unknown to the remote node, and this test failed. Since this test is intended to take place on the remote node, localhost should work fine.
arm4b
approved these changes
Jan 24, 2017
There was a problem hiding this comment.
Looks safe, if nginx config is not changed https://github.com/StackStorm/st2/blob/master/conf/nginx/st2.conf#L10 to use specific virtual host, what will be an option for improvement in some future version of ansible-st2.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous variable resulted in a hostname that was unknown to the remote node, (at least when running in AWS) and this test failed.
Since this test is intended to take place on the node where stackstorm is installed/running, localhost should work fine.