-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vagrantfile update for Multi VM support #72
Conversation
Got this error with u14 bento box couple of times:
|
end | ||
if name == :u14 | ||
vm_config.vm.box = 'ubuntu/trusty64' | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can define box
for every VM in VIRTUAL_MACHINES
constant, what will allow us to simplify this block:
vm_config.vm.box = cfg[:box]
VAGRANTFILE_API_VERSION = '2' | ||
VIRTUAL_MACHINES = { | ||
:u14 => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
u14
is assumption we made internally, but for other users of this repo and contributors it could be confusing.
I think vagrant up ubuntu14
is more expected here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of small change requests.
Besides of that, looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice 👍
Reference: #67