Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagrantfile update for Multi VM support #72

Merged
merged 4 commits into from
Jan 6, 2017

Conversation

humblearner
Copy link
Contributor

@humblearner humblearner commented Jan 6, 2017

Reference: #67

@humblearner
Copy link
Contributor Author

Got this error with u14 bento box couple of times:

TASK [ANXS.postgresql : PostgreSQL | Make sure the PostgreSQL users are present] ***
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in position 29: ordinal not in range(128)
fatal: [u14]: FAILED! => {"failed": true, "msg": "Unexpected failure during module execution.", "stdout": ""}

@humblearner humblearner changed the title VagrantFile Update for multiVM support Vagrantfile update for Multi VM support Jan 6, 2017
end
if name == :u14
vm_config.vm.box = 'ubuntu/trusty64'
end
Copy link
Member

@arm4b arm4b Jan 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can define box for every VM in VIRTUAL_MACHINES constant, what will allow us to simplify this block:

vm_config.vm.box = cfg[:box]

VAGRANTFILE_API_VERSION = '2'
VIRTUAL_MACHINES = {
:u14 => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u14 is assumption we made internally, but for other users of this repo and contributors it could be confusing.
I think vagrant up ubuntu14 is more expected here.

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of small change requests.

Besides of that, looks good.

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice 👍

@humblearner humblearner merged commit d745d14 into master Jan 6, 2017
@humblearner humblearner deleted the rhel_VagrantFile_support branch January 6, 2017 19:54
@arm4b arm4b added this to the v0.6.0 milestone Jan 11, 2017
@arm4b arm4b added the feature label Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants