Updated kitchen and travis to support centos

[Mierdin]

Closes #68 and #69

[arm4b]

Just checked, you were right.
There is centos option, according to https://github.com/test-kitchen/kitchen-docker#platform

[Mierdin]

Cool. I also installed test kitchen on my laptop last night so I am not flying blind any more

…

On Jan 6, 2017 5:33 AM, "Eugen C." ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In .kitchen.yml <#71 (review)> : > @@ -33,6 +33,18 @@ platforms: run_command: /sbin/init volume: - /sys/fs/cgroup:/sys/fs/cgroup:ro + - name: centos-6 + driver_config: + image: stackstorm/packagingtest:centos6 + platform: rhel + run_command: /sbin/init + - name: centos-7 + driver_config: + image: stackstorm/packagingtest:centos7 + platform: rhel I double-checked, you were right. There is centos option according to https://github.com/test- kitchen/kitchen-docker#platform — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#71 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AECM-_o0uC3OqHBkbkXGy345qk0TYuOsks5rPkKYgaJpZM4LcRGx> .

[arm4b]

I investigated the build failure.
That's because we generate /etc/ssh/ssh_host_rsa_key already in our Centos Dockerfiles: https://github.com/StackStorm/st2-dockerfiles/blob/master/packagingtest/centos7/systemd/Dockerfile#L63 (and here's why it's needed).

I've submitted patch in kitchen-docker test-kitchen/kitchen-docker#253, but in a meantime you can try to use custom intermediate Dockerfile for centos6 and centos7 for kitchen-docker to work, see:

• https://github.com/test-kitchen/kitchen-docker#dockerfile
• https://github.com/test-kitchen/kitchen-docker/blob/master/test/Dockerfile
• https://github.com/test-kitchen/kitchen-docker/blob/b2b44bacb39673722454cf35762fd7b76037b80d/lib/kitchen/driver/docker.rb#L183-L277

Hope it'll unblock you.

[Mierdin]

Yup that's the plan. Thanks

…

On Jan 6, 2017 6:49 AM, "Eugen C." ***@***.***> wrote: <https://camo.githubusercontent.com/40555ddb7e4a22a9e3d177fc492146ed7cad6a53/68747470733a2f2f692e696d6775722e636f6d2f67666163345a352e706e67> I investigated the build failure. That's because we generate /etc/ssh/ssh_host_rsa_key already in our Dockerfile: https://github.com/StackStorm/st2-dockerfiles/blob/master/ packagingtest/centos7/systemd/Dockerfile#L63 (and here's <http://ask.xmodulo.com/sshd-error-could-not-load-host-key.html> why it's needed). I've submitted patch in kitchen-docker test-kitchen/kitchen-docker#253 <test-kitchen/kitchen-docker#253>, but in a meantime you can try to use custom intermediate Dockerfile for centos6 and centos7 for kitchen-docker to work, see: - https://github.com/test-kitchen/kitchen-docker#dockerfile - https://github.com/test-kitchen/kitchen-docker/blob/ master/test/Dockerfile - https://github.com/test-kitchen/kitchen-docker/blob/ b2b44bacb39673722454cf35762fd7b76037b80d/lib/kitchen/driver/ docker.rb#L183-L277 <https://github.com/test-kitchen/kitchen-docker/blob/b2b44bacb39673722454cf35762fd7b76037b80d/lib/kitchen/driver/docker.rb#L183-L277> Hope it'll unblock you. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#71 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AECM-wldz8k7D0bzCbRvf2ZlLiw2sFhlks5rPlSFgaJpZM4LcRGx> .

[arm4b]

It would be nice to hide these intermediate Dockerfiles under .kitchen/ dir (for example).
Just to avoid confusion from users when we place Dockerfile in the root dir of repo.

[jvrplmlmn]

FWIW this issue StackStorm/chef-stackstorm#30 in the chef-stackstorm discusses why you shouldn't use the stackstorm/packagingtest Docker images for testing.

[Mierdin]

Closing, as #81 and #82 solve this problem more correctly.