Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and upgrade deprecated actions #323

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Update and upgrade deprecated actions #323

merged 3 commits into from
Dec 5, 2022

Conversation

mamercad
Copy link
Contributor

@mamercad mamercad commented Dec 4, 2022 •
edited
Loading

Update the deprecated action actions/setup-ruby@v1 to ruby/setup-ruby@v1. Upgrade actions/checkout, actions/cache, and technote-space/workflow-conclusion-action for the Node 12 (in favor of 16) deprecation. Looks like I was running into "rate limiting" ... I pushed max-parallel: 1 as a shot in the dark.

@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Dec 4, 2022
@cognifloyd
Copy link
Member

cognifloyd commented Dec 5, 2022 •
edited
Loading

I suspect you need to also switch to runs-on: ubuntu-20.04 instead of ubuntu-latest. I had to do that with the main st2 repo because latest switched to ubuntu-22.04

@mamercad
Copy link
Contributor Author

mamercad commented Dec 5, 2022

I suspect you need to also switch to runs-on: ubuntu-20.04 instead of ubuntu-latest. I had to do that with the main st2 repo because latest switched to ubuntu-22.04

Ah yes, I've been burned by this elsewhere :loading:

arm4b
arm4b approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the CI fix!

@arm4b arm4b merged commit ebc0296 into StackStorm:master Dec 5, 2022
@mamercad mamercad deleted the update-deprecated-actions branch December 5, 2022 18:44
@arm4b arm4b mentioned this pull request Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arm4b arm4b arm4b approved these changes

Assignees
No one assigned
Labels
size/S PR that changes 10-29 lines. Very easy to review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mamercad @cognifloyd @arm4b