Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for RBAC mappings #319

Merged
merged 5 commits into from
Jul 7, 2022
Merged

Add support for RBAC mappings #319

merged 5 commits into from
Jul 7, 2022

Conversation

mamercad
Copy link
Contributor

Fixes #318.

@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Jun 24, 2022
amanda11
amanda11 reviewed Jun 27, 2022
View reviewed changes
Copy link
Contributor

@amanda11 amanda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the contribution. Just a couple of minor comments.

roles/StackStorm.st2/defaults/main.yml Outdated Show resolved Hide resolved
roles/StackStorm.st2/templates/rbac_mappings/mappings.yml.j2 Show resolved Hide resolved
@mamercad
Copy link
Contributor Author

FWIW; I'm running this branch locally 😄

@mamercad
Copy link
Contributor Author

Err; I think indent(2) only indents the first line ...

@mamercad
Copy link
Contributor Author

My deployment is breaking now (as far as RBAC mappings go), here's one of the diffs:

-group: redacted
-roles:
-- admin
+  group: redacted
+  roles:
+  - admin

@mamercad
Copy link
Contributor Author

After reverting indent(2), my deployment is happy again.

@mamercad mamercad requested a review from amanda11 July 5, 2022 12:51
amanda11
amanda11 approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@amanda11 amanda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks for the contribution.

@amanda11 amanda11 merged commit 8f83ad7 into StackStorm:master Jul 7, 2022
@mamercad mamercad deleted the issue-318 branch July 7, 2022 11:21
@arm4b arm4b mentioned this pull request Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanda11 amanda11 amanda11 approved these changes

Assignees
No one assigned
Labels
size/M PR that changes 30-99 lines. Good size to review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for RBAC mappings
2 participants
@mamercad @amanda11