Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EWC support & move LDAP/RBAC configuration to Stackstorm.st2 #290

Merged
merged 23 commits into from
May 6, 2021
Merged

Remove EWC support & move LDAP/RBAC configuration to Stackstorm.st2 #290

merged 23 commits into from
May 6, 2021

Conversation

winem
Copy link
Contributor

@winem winem commented Mar 18, 2021

This PR:

  • removes the EWC roles
  • removes EWC/BWS from the README
  • updates links to the documentation from ewc-docs to docs.stackstorm.com
  • adds the ability to disable RBAC again (this was not possible before because the RBAC playbook was imported only when RBAC should be enabled; so disabling RBAC in the ansible variables did not actually disable it in the st2 deployment

close #260

arm4b
arm4b suggested changes Mar 19, 2021
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+112 −740 - nice diff, love it! Makes things so much easier now 👍

Some early pointers for this PR, - looks also that the RBAC logic is missing notifying the st2-apply-rbac-definitions --config-file /etc/st2/st2.conf to apply the new definitions & assignments.

roles/StackStorm.st2/defaults/main.yml Show resolved Hide resolved
roles/StackStorm.st2/tasks/auth-rbac.yml Outdated Show resolved Hide resolved
@arm4b
Copy link
Member

arm4b commented Mar 19, 2021

Related to this PR, st2docs may need an update: https://docs.stackstorm.com/install/ansible.html to reflect this new change.

It's possible to include the instructions from the history to provide the RBAC & LDAP configuration example:
https://github.com/StackStorm/st2docs/pull/1020/files#diff-3f8f088be48f3933baeab8a1722d69bb0c9f2351670eaf2f2f4a2c9d83058e9c

@winem
Copy link
Contributor Author

winem commented Mar 20, 2021

Related to this PR, st2docs may need an update: https://docs.stackstorm.com/install/ansible.html to reflect this new change.

It's possible to include the instructions from the history to provide the RBAC & LDAP configuration example:
https://github.com/StackStorm/st2docs/pull/1020/files#diff-3f8f088be48f3933baeab8a1722d69bb0c9f2351670eaf2f2f4a2c9d83058e9c

I'll look into that over the weekend.

@winem winem mentioned this pull request Mar 21, 2021
Merged
@winem
Copy link
Contributor Author

winem commented Mar 21, 2021

I provided a PR for the st2docs update: StackStorm/st2docs#1061

arm4b
arm4b reviewed Mar 22, 2021
View reviewed changes
.travis.yml Show resolved Hide resolved
@pull-request-size pull-request-size bot added the size/XL PR that changes 500-999 lines. Consider splitting work into several ones that easier to review. label Mar 24, 2021
arm4b
arm4b reviewed Mar 30, 2021
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for migrating the RBAC smoketests.

All looks good, however based on TravisCI jobs RBAC smoke tests are skipped. Could we enable them to make sure that the added functionality is tested in CI?

roles/StackStorm.st2smoketests/defaults/main.yml Outdated Show resolved Hide resolved
@winem
Copy link
Contributor Author

winem commented Apr 25, 2021

Enabling the RBAC tests take a bit more time than expected but I'm on it and provide them in the next days.

arm4b
arm4b suggested changes Apr 29, 2021
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests are failing on idempotence checks.

I've provided more pointers around the RBAC some tests, hope that helps.

roles/StackStorm.st2smoketests/tasks/st2rbac_verification.yml Outdated Show resolved Hide resolved
roles/StackStorm.ewc_smoketests/tasks/main.yml Show resolved Hide resolved
roles/StackStorm.st2smoketests/tasks/main.yml Show resolved Hide resolved
@winem winem changed the title Remove EWC support & move LDAP/RBAC configuration to Stackstorm.st2 WIP: Remove EWC support & move LDAP/RBAC configuration to Stackstorm.st2 Apr 29, 2021
@winem winem marked this pull request as draft April 29, 2021 20:54
@winem winem marked this pull request as ready for review May 1, 2021 22:05
@winem winem changed the title WIP: Remove EWC support & move LDAP/RBAC configuration to Stackstorm.st2 Remove EWC support & move LDAP/RBAC configuration to Stackstorm.st2 May 1, 2021
@winem
Copy link
Contributor Author

winem commented May 1, 2021

@armab this PR passes the tests now and I ran them multiple times in my own dev environment. So I hope I got everything right now.

arm4b
arm4b approved these changes May 2, 2021
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍

Thanks a lot for the diligence refactoring this.

@winem winem merged commit 1551a3d into StackStorm:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arm4b arm4b arm4b approved these changes

Assignees
No one assigned
Labels
breaking change feature size/XL PR that changes 500-999 lines. Consider splitting work into several ones that easier to review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EWC/Enterprise transition to OpenSource
2 participants
@winem @arm4b