Include centos 7 in condition for installing st2 pack in smoketests #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
surfer190
changed the title
|
The reason we exclude EL6 from some of the tasks comes from the fact that specific Ansible/Jinja functionality we need is not possible in EL6. See #250 for more info. Smoketests with pack install are trying to test default |
arm4b
reviewed
Sep 12, 2019
|
Ok @armab updated. Why couldn't I just approve your changes from here? Anyway made the change again in my fork and pushed. |
arm4b
reviewed
Sep 13, 2019
Remove the when condition completely Co-Authored-By: Eugen C. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #251
I have not added any tests.
I am also unsure why there is a condition just for red hat version 6 to install the st2 pack but the next task to
Verify if st2 pack was installedhas no such condition.