AutoConfigure detects protocol failure HeartBeats allow ReplicaReconfig #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We looked at this in the weekly call - I agree with the issue, but am very hesitant to change the result processor behavior. I've pitched an alternative solution in #2784. The problem with failing on the result processor is that we get some invalid responses from some servers and proxies that today would fall back to using the configured state, but this would change that situation into looping on connection fails, so I'd rather not shift any on that front :) |
NickCraver
added a commit
that referenced
this pull request
Sep 3, 2024
…cks (#2784) * Fix #2778: Run CheckInfoReplication even with HeartbeatConsistencyChecks This is an issue identified in ##2778 and #2779 where we're not updating replication topology if heartbeat consistency checks are enabled because we exit the `if` structure early. This still runs that check if it's due in both cases, without changing the behavior of the result processor. * Add release notes
|
Closing this out as a PR, but will be fixed in a release we're cutting shortly. Thanks a ton for raising this to our attention, and included you in the release notes on this as well (can remove if you'd rather not, but we're big on credit for things). Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting to a Redis Cluster and enabling the
HeartbeatConsistencyChecksthis preventsCheckInfoReplication()from ever being called andConfigCheckSecondsis no longer respected.This change will do the replication check but adds the
RecordConnectionFailedlike theTracerProcessorwas doing forHeartbeatConsistencyChecks.I haven't been able to run all the tests locally so I'm not sure if this change breaks anything, but was able to build the package and use it successfully.
The main thing I would be concerned about is if there are scenarios that AutoConfigureProcessor shouldn't parse anything, this would be recorded as a protocol failure.
This should fix the issue mentioned in #2778.