-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for CLIENT KILL MAXAGE #2727
Conversation
Reviewed on the call today - in general, this pattern won't work due to the server-side API supporting
This wouldn't be very dissimilar to the constructors you have now in terms of one-per, but we can make it intuitive and pit-of-success here for users to do the right thing. And we can make it write the message directly on the backend since it's in the base library. Picture for example: IServer.ClientKillAsync(new ClientKillFilter().WithAddr(...).WithSkipMe(true));` Thoughts? |
hey @NickCraver , sounds nice and clear ! please take a look with new commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a look here local and pushed up some fixes, but it looks like we don't implement the LADDR
or USER
filters in the actual send, so we need to add those and preferably add tests around the filter calling each command and making sure these are set.
@NickCraver , yeah i missed that two. Adding them.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest is looking good - thank you!
Closes/Fixes #2726
added two overloads and use a filter object to avoid a breaking change.