Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify meaning of RedisValue.IsInteger #2420

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Clarify meaning of RedisValue.IsInteger #2420

merged 3 commits into from
Mar 30, 2023

Conversation

mgravell
Copy link
Collaborator

See #2418

(I also looked at custom == operators, but that created API ambiguity between == on RedisValue?, and null literals

@mgravell mgravell requested a review from NickCraver March 30, 2023 11:27
NickCraver
NickCraver approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mgravell mgravell merged commit f690d16 into main Mar 30, 2023
@mgravell mgravell deleted the issue2418 branch March 30, 2023 15:07
@NickCraver NickCraver mentioned this pull request Apr 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCraver NickCraver NickCraver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgravell @NickCraver