Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support SPOP count parameter #203

Closed
doodoori2 opened this issue May 6, 2015 · 3 comments
Closed

support SPOP count parameter #203

doodoori2 opened this issue May 6, 2015 · 3 comments
Assignees
@NickCraver
Labels
⚙️ area:commands ➕ enhancement
Milestone
2.0

Comments

@doodoori2
Copy link

SPOP key [count] http://redis.io/commands/spop
Redis command SPOP can use with default parameter 'count' .

But currently there is no parameter for count option.
RedisValue SetPop(RedisKey key, CommandFlags flags = CommandFlags.None);

I think need to implement below method.
RedisValue SetPop(RedisKey key, long count = 0, CommandFlags flags = CommandFlags.None);

Thanks
@NickCraver NickCraver added this to the 2.0 milestone Sep 2, 2017
@NickCraver NickCraver mentioned this issue May 28, 2018
Closed
12 tasks
@NickCraver
Copy link
Collaborator

Added to #528 for tracking.

@NickCraver NickCraver self-assigned this Jul 2, 2018
NickCraver added a commit that referenced this issue Jul 3, 2018
@NickCraver
Add SetPop/SetPopAsync count overloads
bf06daf 
This API was missing - resolves #203
@NickCraver NickCraver mentioned this issue Jul 3, 2018
Merged
@NickCraver
Copy link
Collaborator

PR open for this in #874

@mgravell mgravell mentioned this issue Jul 4, 2018
Merged
19 tasks
NickCraver added a commit that referenced this issue Jul 4, 2018
@NickCraver
Add SetPop/SetPopAsync count overloads
53127b8 
This API was missing - resolves #203
@NickCraver
Copy link
Collaborator

Merged into pipelines, closing this out as complete for v2 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NickCraver NickCraver

Labels
⚙️ area:commands ➕ enhancement
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@doodoori2 @NickCraver