Tests: Increase overall stability (#2548)

Fixes: - `DisconnectAndNoReconnectThrowsConnectionExceptionAsync`: Under load, we're not connecting in 50ms for the initial thing, and stability > speed, so give a little on this test to help out. Average runtime will be higher, but that's way better than sporadically failing. - `Roles`: Don't assume we're in the initial primary/replica setup (we may have failed over) and make it work either way.
StackExchange · Oct 31, 2023 · c05179f · c05179f
1 parent 8f7e040
commit c05179f
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 16 deletions.
diff --git a/tests/StackExchange.Redis.Tests/AbortOnConnectFailTests.cs b/tests/StackExchange.Redis.Tests/AbortOnConnectFailTests.cs
@@ -1,4 +1,5 @@
-using System;
+using StackExchange.Redis.Tests.Helpers;
+using System;
 using System.Threading.Tasks;
 using Xunit;
 using Xunit.Abstractions;
@@ -92,9 +93,9 @@ private ConnectionMultiplexer GetWorkingBacklogConn() =>
     {
         AbortOnConnectFail = false,
         BacklogPolicy = policy,
-        ConnectTimeout = 50,
+        ConnectTimeout = 500,
         SyncTimeout = 400,
         KeepAlive = 400,
         AllowAdmin = true,
-    };
+    }.WithoutSubscriptions();
 }
diff --git a/tests/StackExchange.Redis.Tests/Helpers/Extensions.cs b/tests/StackExchange.Redis.Tests/Helpers/Extensions.cs
@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using System.Runtime.InteropServices;
 using Xunit.Abstractions;
 
@@ -26,4 +27,10 @@ static Extensions()
     }
 
     public static void WriteFrameworkVersion(this ITestOutputHelper output) => output.WriteLine(VersionInfo);
+
+    public static ConfigurationOptions WithoutSubscriptions(this ConfigurationOptions options)
+    {
+        options.CommandMap = CommandMap.Create(new HashSet<string>() { nameof(RedisCommand.SUBSCRIBE) }, available: false);
+        return options;
+    }
 }
diff --git a/tests/StackExchange.Redis.Tests/RoleTests.cs b/tests/StackExchange.Redis.Tests/RoleTests.cs
@@ -1,4 +1,5 @@
-using Xunit;
+using System.Linq;
+using Xunit;
 using Xunit.Abstractions;
 
 namespace StackExchange.Redis.Tests;
@@ -8,38 +9,70 @@ public class Roles : TestBase
 {
     public Roles(ITestOutputHelper output, SharedConnectionFixture fixture) : base(output, fixture) { }
 
+    protected override string GetConfiguration() => TestConfig.Current.PrimaryServerAndPort + "," + TestConfig.Current.ReplicaServerAndPort;
+
     [Theory]
     [InlineData(true)]
     [InlineData(false)]
     public void PrimaryRole(bool allowAdmin) // should work with or without admin now
     {
         using var conn = Create(allowAdmin: allowAdmin);
-        var server = conn.GetServer(TestConfig.Current.PrimaryServerAndPort);
-
+        var servers = conn.GetServers();
+        Log("Server list:");
+        foreach (var s in servers)
+        {
+            Log($"  Server: {s.EndPoint} (isConnected: {s.IsConnected}, isReplica: {s.IsReplica})");
+        }
+        var server = servers.First(conn => !conn.IsReplica);
         var role = server.Role();
+        Log($"Chosen primary: {server.EndPoint} (role: {role})");
+        if (allowAdmin)
+        {
+            Log($"Info (Replication) dump for {server.EndPoint}:");
+            Log(server.InfoRaw("Replication"));
+            Log("");
+
+            foreach (var s in servers)
+            {
+                if (s.IsReplica)
+                {
+                    Log($"Info (Replication) dump for {s.EndPoint}:");
+                    Log(s.InfoRaw("Replication"));
+                    Log("");
+                }
+            }
+        }
         Assert.NotNull(role);
         Assert.Equal(role.Value, RedisLiterals.master);
         var primary = role as Role.Master;
         Assert.NotNull(primary);
         Assert.NotNull(primary.Replicas);
-        Log($"Searching for: {TestConfig.Current.ReplicaServer}:{TestConfig.Current.ReplicaPort}");
-        Log($"Replica count: {primary.Replicas.Count}");
-        Assert.NotEmpty(primary.Replicas);
-        foreach (var replica in primary.Replicas)
+
+        // Only do this check for Redis > 4 (to exclude Redis 3.x on Windows).
+        // Unrelated to this test, the replica isn't connecting and we'll revisit swapping the server out.
+        // TODO: MemuraiDeveloper check
+        if (server.Version > RedisFeatures.v4_0_0)
         {
-            Log($"  Replica: {replica.Ip}:{replica.Port} (offset: {replica.ReplicationOffset})");
-            Log(replica.ToString());
+            Log($"Searching for: {TestConfig.Current.ReplicaServer}:{TestConfig.Current.ReplicaPort}");
+            Log($"Replica count: {primary.Replicas.Count}");
+
+            Assert.NotEmpty(primary.Replicas);
+            foreach (var replica in primary.Replicas)
+            {
+                Log($"  Replica: {replica.Ip}:{replica.Port} (offset: {replica.ReplicationOffset})");
+                Log(replica.ToString());
+            }
+            Assert.Contains(primary.Replicas, r =>
+                r.Ip == TestConfig.Current.ReplicaServer &&
+                r.Port == TestConfig.Current.ReplicaPort);
         }
-        Assert.Contains(primary.Replicas, r =>
-            r.Ip == TestConfig.Current.ReplicaServer &&
-            r.Port == TestConfig.Current.ReplicaPort);
     }
 
     [Fact]
     public void ReplicaRole()
     {
         using var conn = ConnectionMultiplexer.Connect($"{TestConfig.Current.ReplicaServerAndPort},allowAdmin=true");
-        var server = conn.GetServer(TestConfig.Current.ReplicaServerAndPort);
+        var server = conn.GetServers().First(conn => conn.IsReplica);
 
         var role = server.Role();
         Assert.NotNull(role);