Skip to content

Commit

Permalink
Hello can be pipelined
Browse files Browse the repository at this point in the history
  • Loading branch information
dbarbosapn committed Sep 4, 2024
1 parent 2b6c84d commit a363abe
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/StackExchange.Redis/ServerEndPoint.cs
Original file line number Diff line number Diff line change
Expand Up @@ -972,8 +972,9 @@ private async Task HandshakeAsync(PhysicalConnection connection, ILogger? log)
if (Multiplexer.RawConfig.TryResp3()) // note this includes an availability check on HELLO
{
log?.LogInformation($"{Format.ToString(this)}: Authenticating via HELLO");
var hello = Message.CreateHello(3, user, password, clientName, CommandFlags.None);
await SendAuthMessageAsync(connection, hello, autoConfig ??= ResultProcessor.AutoConfigureProcessor.Create(log)).ForAwait();
var hello = Message.CreateHello(3, user, password, clientName, CommandFlags.FireAndForget);
hello.SetInternalCall();
await WriteDirectOrQueueFireAndForgetAsync(connection, hello, autoConfig ??= ResultProcessor.AutoConfigureProcessor.Create(log)).ForAwait();

// note that the server can reject RESP3 via either an -ERR response (HELLO not understood), or by simply saying "nope",
// so we don't set the actual .Protocol until we process the result of the HELLO request
Expand Down

0 comments on commit a363abe

Please sign in to comment.