Fix #2426 - don't restrict multi-slot operations on envoy proxy (#2428)

StackExchange · Apr 3, 2023 · 571d832 · 571d832
1 parent 8872553
commit 571d832
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/docs/ReleaseNotes.md b/docs/ReleaseNotes.md
@@ -8,7 +8,7 @@ Current package versions:
 
 ## Unreleased
 
-No pending unreleased changes.
+- Fix [#2426](https://github.com/StackExchange/StackExchange.Redis/issues/2426): Don't restrict multi-slot operations on Envoy proxy; let the proxy decide ([#2428 by mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/2428))
 
 ## 2.6.104
 

diff --git a/src/StackExchange.Redis/ServerSelectionStrategy.cs b/src/StackExchange.Redis/ServerSelectionStrategy.cs
@@ -140,10 +140,15 @@ private static unsafe int GetClusterSlot(ReadOnlySpan<byte> blob)
                 // strictly speaking some proxies use a different hashing algorithm, but the hash-tag behavior is
                 // the same, so this does a pretty good job of spotting illegal commands before sending them
                 case ServerType.Twemproxy:
-                case ServerType.Envoyproxy:
                     slot = message.GetHashSlot(this);
                     if (slot == MultipleSlots) throw ExceptionFactory.MultiSlot(multiplexer.RawConfig.IncludeDetailInExceptions, message);
                     break;
+                /* just shown for completeness
+                case ServerType.Standalone: // don't use sharding
+                case ServerType.Envoyproxy: // defer to the proxy; see #2426
+                default: // unknown scenario; defer to the server
+                    break;
+                */
             }
             return Select(slot, message.Command, message.Flags, allowDisconnected);
         }