Lightning compatibility fix #281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer lighting versions move `rank_zero_only` from the distributed subpackage back to utilities. This commit adds a try-except to catch that import error, and retry with the alternative.
Fedee120
approved these changes
Dec 4, 2023
soulteary
approved these changes
Jan 17, 2024
This was referenced Jan 17, 2024
|
@rromb , @hardmaru , could this can merge? If this change wants to be merged, is there anything else that needs to be done? If it completes the merge, the downstream repository can normally use the complete PyTorch. 2.x software and obtain higher performance. For example: Stable Diffusion WebUI, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm unsure if this repository is still maintained, but I had to resolve this on my own so I figured I'd open a PR as well in case it still is maintained.
Due to a change in lightning's tree structure there will be an import failure if someone has to upgrade lighting, which was the case for me.
This commit just changes that one import line and attempt to import assuming it's the new version, and if it fails it'll fall back to trying to import the old one.