Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for presence of dotenv before using #66

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Test for presence of dotenv before using #66

merged 1 commit into from
Sep 30, 2022

Conversation

chigozienri
Copy link
Contributor

May solve #21

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chigozienri chigozienri mentioned this pull request Sep 28, 2022
Open
@johnsabath
Copy link
Contributor

If this does end up solving the issue, I would recommend leaving the dependency in the setup.py to avoid a breaking change in behavior, but leaving a note to make it optional in the next major version release since it's non-critical.

dmarx
dmarx approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@dmarx dmarx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice workaround

@dmarx dmarx merged commit d03aec0 into main Sep 30, 2022
@dmarx dmarx deleted the cnri.dotenv-optional branch October 13, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmarx dmarx dmarx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chigozienri @johnsabath @dmarx