-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds pangolin 4.3.1 and pangolin-data 1.23 #767
Conversation
…rade to usher 0.6.3 when it is available on bioconda
Sorry for getting to this so late! |
Actually, I just realized that it was still a draft. My apologies for filling up your inbox!!! |
No worries! I may end up just going with usher 0.6.2 instead of waiting for 0.6.3 to be released. Probably more important to get the ability to detect the latest lineages instead of worrying about a bug with calling ancient A lineages.... |
OK this is ready for review & deployment. I don't want to wait for the next version of usher to be released to get this image published & available. I added a warning to the README.md for this docker image and will communicate the edge case bug when announcing that the docker image is available to slacks/elsewhere We can upgrade to usher v0.6.3 the next time we release a docker image for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good!
I have merged this PR, but I am going to let you push to dockehub and quay. I think that it would use the tag '4.3.1-pdata-1.23', but I'd rather be "safe than sorry". :D |
added dockerfile for pangolin 4.3.1 and pdata 1.23.
Still need to upgrade to usher 0.6.3 when it is available on bioconda due to the edge case bug mentioned in the pangolin-assignment release: https://github.com/cov-lineages/pangolin-assignment/releases/tag/v1.23 . Set this PR as a draft for now.Changes from previous dockerfile:
(when available) upgrade to usher 0.6.3We are sticking with v0.6.2Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15
)spades/3.12.0/Dockerfile
)shigatyper/2.0.1/test.sh
)spades/3.12.0/README.md
)