Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pangolin 4.2 dockerfile to use pdata 1.18.1.1 #622

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

kapsakcj
Copy link
Collaborator

@kapsakcj kapsakcj commented Feb 24, 2023

Also bumped dockerfile.version to 3 (since I forgot to bump on last iteration). This fixes a bug when using pangolin --use-assignment-cache mode with very recent samples (i.e. brand new lineages). More info here:

https://github.com/cov-lineages/pangolin-data/releases/tag/v1.18.1.1
cov-lineages/pangolin-data#35

I'm happy to trigger the deploy workflow. Planning to use the docker image name and tag staphb/pangolin:4.2-pdata-1.18.1.1 and overwrite :latest

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

…le.version to 3 (forgot to bump on last iteration)
@erinyoung
Copy link
Contributor

Sorry for not noticing the lack of Dockerfile version in the last PR!

I don't have any comments. I'm going to merge this PR, but I'll let you deploy to dockerhub and quay.

@erinyoung erinyoung merged commit fb34c65 into master Feb 24, 2023
@kapsakcj kapsakcj deleted the cjk-pdata-1.18.1.1 branch February 24, 2023 20:53
@kapsakcj
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants