Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Controls... #19

Merged
merged 7 commits into from
Oct 11, 2017
Merged

New Controls... #19

merged 7 commits into from
Oct 11, 2017

Conversation

idoodler
Copy link
Contributor

@idoodler idoodler commented Oct 7, 2017

Everything has been tested by me in my home.

- Modernized code
- Added Support for new LightControllerV2 and ColorPickerV2
- Added correct changelog
@DerFlash
Copy link
Contributor

DerFlash commented Oct 8, 2017

You only support multiple items with the same name within the ItemFactorys itemList, and I assume it then just works for you, because in fact you don't really have "same item names" after you also appended the room name to the item name now*
If they really would have the same name in the same room, your code would still fail.
See my additions in AbstractItem.js in my pull request #12 for fixing this.

* personally, I don't really like doing this. It's not the original name and will result in bad HomeKit behaviour like now the HomeKit app no longer can "guess" the rooms main light (based on the fact that it has the exact name of its room)

Still, this is another good heads up here. Would be nice if @Sroose would pick up the good work again.

Kind regards
Björn

@idoodler
Copy link
Contributor Author

idoodler commented Oct 8, 2017

@DerFlash Thats right. My main intention in appending the room to the controls name was to better identify the control in the initial setup process, you can easily change it in this process. It would be great, if @Sroose also accepts #12.

@DerFlash
Copy link
Contributor

DerFlash commented Oct 8, 2017

@idoodler Good point about changing the name back in the adding process later. I'll revert my opinion. You're right, it may help in bigger setups.

@tomasbarej
Copy link

Tested yesterday and works good in my Loxone 9 setup. There was just one problem with an loxone function block that was not assigned to any room and forbid me to initiate the homebridge plugin.

Condition to check that controlRoom variable isn't an undefined needs to be added in ItemFactory.js
controlRoom = factory.roomList[control.room];

@idoodler
Copy link
Contributor Author

@tomasbarej I just added a check for the undefined room property.

@Djhaico
Copy link

Djhaico commented Oct 10, 2017

Hey Guys,

Nice project, great work!

Im new at this form,and i installed homekit for my Loxone project. I can read with my ipad what light is on or off, but when i give a command to swhitch the light on, the light doesn't go on. Command is sent to loxone, but Loxone doesn't response.

Is this a bug, or im not on the right sofware version ?
Homebridge API Version 2.2

Can someone help me with this problem?

Kind regards,

Haico

@Sroose Sroose merged commit 5f7f737 into Sroose:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants