-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Controls... #19
New Controls... #19
Conversation
- Modernized code - Added Support for new LightControllerV2 and ColorPickerV2
- Added correct changelog
You only support multiple items with the same name within the ItemFactorys itemList, and I assume it then just works for you, because in fact you don't really have "same item names" after you also appended the room name to the item name now* * personally, I don't really like doing this. It's not the original name and will result in bad HomeKit behaviour like now the HomeKit app no longer can "guess" the rooms main light (based on the fact that it has the exact name of its room) Still, this is another good heads up here. Would be nice if @Sroose would pick up the good work again. Kind regards |
@idoodler Good point about changing the name back in the adding process later. I'll revert my opinion. You're right, it may help in bigger setups. |
Tested yesterday and works good in my Loxone 9 setup. There was just one problem with an loxone function block that was not assigned to any room and forbid me to initiate the homebridge plugin. Condition to check that controlRoom variable isn't an undefined needs to be added in ItemFactory.js |
@tomasbarej I just added a check for the undefined room property. |
Hey Guys, Nice project, great work! Im new at this form,and i installed homekit for my Loxone project. I can read with my ipad what light is on or off, but when i give a command to swhitch the light on, the light doesn't go on. Command is sent to loxone, but Loxone doesn't response. Is this a bug, or im not on the right sofware version ? Can someone help me with this problem? Kind regards, Haico |
Everything has been tested by me in my home.