Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dependabot.yml #1179

Closed
wants to merge 1 commit into from
Closed

Create dependabot.yml #1179

wants to merge 1 commit into from

Conversation

slondr
Copy link
Member

@slondr slondr commented Mar 3, 2023

This enables the Dependabot feature which submits PRs for dep upgrades even when they aren't security-related.

I have no idea if this would be useful or not but I figure hey why not try it out

This enables the Dependabot feature which submits PRs for dep upgrades even when they aren't security-related
@slondr slondr self-assigned this Mar 3, 2023
@slondr slondr requested a review from a team March 3, 2023 00:01
@slondr slondr marked this pull request as ready for review March 3, 2023 00:01
@eladyn
Copy link
Member

eladyn commented Mar 6, 2023

In general, I like having some workflow that regularly updates the dependencies. Otherwise, in PRs that need it (e.g., #1174) I have to run cargo update and end up having massive line change counts.

However, I'm not very happy with the way that dependabot solves this (individual PR's for each dependency) as this creates a lot of noise in PRs and especially since we have this 2-reviewer policy isn't as easy to act on as it should be. I'd rather have it like it was proposed here, since this project depends on a massive amount of crates and weekly batch updates would be much more manageable.

Apart from that, I don't think updating Cargo.lock does have major advantages, since cargo seems to somehow ignore the file anyway except when using --locked. (at least from my experience)

But if you have some advantages in mind that I didn't think of, please let me know. :)

@slondr
Copy link
Member Author

slondr commented Mar 9, 2023

Hey, fair enough. I sub'd to that dependabot issue - we can continue to handle this manually for now.

@slondr slondr closed this Mar 9, 2023
@slondr slondr deleted the dependabot-update branch March 9, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants