Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated mods list #957

Merged
merged 7 commits into from
Apr 25, 2023
Merged

Conversation

mosemister
Copy link
Member

@mosemister mosemister commented Apr 21, 2023

Updates the mods list to api 8

Main Changes

When it comes to 1.16.5 mod issues, i found a lot more then 1.12.2 on Github, most without solutions. Not sure if the stance on this sort of thing was to ignore the ones without a solution or that the docs weren't updated for a while or there was generally not too many 1.12.2 issues. Eitherway I have included the ones without any issues as I believe that sort of information should be out there stating I am aware of the issue.

For this reason I have also included a github issue tag for all issues (except abnormal core .... as I couldnt find one -> took the discord pinned as the issue) so if there is a update to any of the incompatibilities then users can click on the github issue and see the update before the docs are updated.

Screen Shot 2023-04-21 at 13 55 56-fullpage

@mosemister mosemister added needs review The submission is ready and needs to be reviewed outdated docs The API has changed and the docs are outdated labels Apr 21, 2023
@mosemister mosemister added this to the v8.0.0 milestone Apr 21, 2023
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea with referencing the issue.
Should we sort the mods alphabetically?

@mosemister
Copy link
Member Author

I like the idea with referencing the issue. Should we sort the mods alphabetically?

Sure, i was going to but Inscrutable wanted to test some of the mods out again. I got the impression to remove the mods whereby the solution is to just update sponge, so didnt want to sort until the mod list is complete

@mosemister
Copy link
Member Author

I like the idea with referencing the issue. Should we sort the mods alphabetically?

I sorted it as SOS is coming

Copy link
Member

@Inscrutable Inscrutable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I have tested and updated a few issues, and I may try testing a few more, but this should be good for now. A few typos and stuff need correcting.
It worries me when we get Mod Packs on the list, because it needs to be narrowed down to a specific mod (or mods) that cause the problem. If we're not careful the issues might just turn out to be duplicates of others.

source/server/spongineer/incompatible.rst Outdated Show resolved Hide resolved
source/server/spongineer/incompatible.rst Outdated Show resolved Hide resolved
source/server/spongineer/incompatible.rst Outdated Show resolved Hide resolved
source/server/spongineer/incompatible.rst Outdated Show resolved Hide resolved
source/server/spongineer/incompatible.rst Outdated Show resolved Hide resolved
source/server/spongineer/incompatible.rst Outdated Show resolved Hide resolved
source/server/spongineer/incompatible.rst Outdated Show resolved Hide resolved
source/server/spongineer/incompatible.rst Outdated Show resolved Hide resolved
source/server/spongineer/incompatible.rst Outdated Show resolved Hide resolved
@mosemister mosemister merged commit 05bf50c into SpongePowered:stable Apr 25, 2023
@mosemister mosemister deleted the api8/mod-compatibility branch April 25, 2023 11:06
@Inscrutable Inscrutable removed the needs review The submission is ready and needs to be reviewed label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outdated docs The API has changed and the docs are outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants