Move isEffect to WeatherEffect, add setEffect #362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @return Whether this strike is an effect | ||
| */ | ||
| boolean isEffect(); |
There was a problem hiding this comment.
Indentation is wrong here.
There was a problem hiding this comment.
javadocs also mention lightning instead of weathereffect
added 2 commits
January 3, 2015 17:25
| @@ -30,5 +30,18 @@ | |||
| * Represents weather, such as {@link Lightning}. | |||
| */ | |||
| public interface WeatherEffect extends Entity { | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
You pasted spaces in here. (Hover the line, then you see it.)
|
Adding to OCD list. |
|
Is this a minor issue? |
|
I'd suggest you give the Contribution guidelines a read. Specifically to take note of this piece:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#346