Add movement threshold configuration #3820
Conversation
There was a problem hiding this comment.
Code looks fine! Not sure if changing existing settings should go into a new major version. cc @Zidane thoughts ?
| if (SpongeGameConfigs.getForWorld(this.player.level).get().movementChecks.player.vehicleMovedTooQuickly) { | ||
| return val; | ||
| private double movementCheck$onVehicleMovedWronglyCheck(final double value) { | ||
| final double threshold = SpongeGameConfigs.getForWorld(this.player.level).get().movementChecks.movedWronglyThreshold; |
There was a problem hiding this comment.
This is using the player's one instead of the vehicle's. You forgot to introduce vehicle-moved-wrongly-threshold
There was a problem hiding this comment.
A previous configuration knob did not exist seperating player and vehicle and Paper/Spigot doesn't have a seperate one for each either I think. If you still think this is useful though I can add it.
There was a problem hiding this comment.
I think it would be useful. It doesn't hide the fact that the same knob is used for both vehicle and players as the other one is separated like that. Also considering players and vehicles have different physics.
|
Good point. I'll add back the old configuration knobs, where if they are false it will act as though the threshold is negative (disable the check), otherwise if it's true it will enable and use the configured threshold (or the default). |
vectrixdevelops
force-pushed
the
feature/movement-threshold-configuration
branch
from
10827d1
to
e269d3c
Compare
Replaces the existing enable/disable movement checks with a customizable threshold. Using negative numbers will disable the movement checks still if desired.