Fix health scaling again #3778
Merged
Fix health scaling again #3778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vectrixdevelops
force-pushed
the
fix/health-scale
branch
from
c801b95
to
3cb4650
Compare
vectrixdevelops
force-pushed
the
fix/health-scale
branch
from
3cb4650
to
99a876e
Compare
vectrixdevelops
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first attempt did not fix the problem correctly, so I've made another fix. This correctly takes into account the maximum health when the health scale is not set. This also caches the maximum attribute to use in calls to
getInternalScaledHealthas an optimization. It removes some of the duplicate code ingetInternalScaledHealthto instead use the cached attributes and callinggetValueto acquire the numeric maximum health value (taking into account modifiers applied by mods).