Fix many WorldManager issues #3702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeregorix
force-pushed
the
fix/worldmanager
branch
from
3406020
to
2c71ecc
Compare
Yeregorix
changed the title
… null key when template is missing
Yeregorix
force-pushed
the
fix/worldmanager
branch
from
bb6c901
to
35d9597
Compare
Zidane
reviewed
Aug 19, 2022
src/main/java/org/spongepowered/common/world/server/SpongeWorldManager.java
Outdated
Show resolved
Hide resolved
Zidane
reviewed
Aug 19, 2022
src/main/java/org/spongepowered/common/world/server/SpongeWorldManager.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected API methods are :
World#save,WorldManager#loadProperties,WorldManager#loadWorld,WorldManager#copyWorldandWorldManager#moveWorld. See the commit descriptions for more details.I also added json indentation when writing templates so it's easier to edit as some server owners may want to edit generation settings.
One problem persists: renaming or copying from a vanilla world to a custom world does not work because custom worlds need a template and vanilla worlds don't have templates.