[API8] BlockStateProperties Registries #3615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the properties used by vanilla are always the same instance. API properties are clones of those. Move duplicate code up into SpongeRegistryHolder. #3611
Faithcaio
force-pushed
the
api8/blockstateproperty
branch
from
eb6a653
to
01cfc63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides registries for BlockStateProperties.
We might want to change them not to be in a registry for API9.
The properties used by vanilla are always the same instance. API properties are now clones of those.
Move duplicate code up into SpongeRegistryHolder.
fixes #3611