Add rudimentary detection of spaces in filenames on Java 8 #3549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a visual - the red arrow on the prompt in my shell indicates a non-zero exit code (but I'd hope System.exit sans security manager worked in Java...):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Zidane There may be a better place for the code, but I figured we probably want to bail out immediately. I think this suffices, but it is in applaunch so just want to make sure it's in the right place before it goes in.
Not using an exception because all that'll happen is we'll print the message, then there will be a stack trace, then everyone won't read the message. If this is the last thing that is printed, and an error code that is non-zero is sent out, at least some panels might detect the crash, preven the auto-restart, and we have a fighting chance that people will read the output.