Another fix of IgniteEntityEvent #3439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImMorpheus
added
system: event
type: bug
Lignium
force-pushed
the
api8/another-fix-of-ignite-entity-event
branch
from
3e72e99
to
4b37410
Compare
|
Does a negative number mean indefinite? |
|
Each tick for a entity which does not burning is executing: |
|
Yes, it makes sense, they're using that field for two different things, and a negative value means something slightly different to a positive one. There is a case for a "fire_immunity" key to expose this, I guess, but not for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the skeletons catch fire during the day, it still throws a negative tick exception, so I just raised the lower bound to zero. This time the final fix, there should be no more exceptions.