Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jansi dep to support ARM64 #3431

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Update jansi dep to support ARM64 #3431

merged 1 commit into from
Jun 17, 2021

Conversation

dualspiral
Copy link
Contributor

See #3429

I haven't got an ARM64 machine up and running to test this (will have to dust off my Raspberry Pi which I think is 64 bit, but I'm hoping someone else will be able to tell me if it works before I get to that tomorrow)

This might not work, or it might not be the best way to do this...

If someone wants to test this, give this a go - spongevanilla-1.16.5-8.0.0-RC0-universal.jar.zip

@dualspiral
Copy link
Contributor Author

It turns out I have a 32bit distro on my Pi, simply as I'm using a model 3B. So, I won't be able to test it, but if someone can verify this works for me, then we can pull it. Alternatively, we wait until jline updates its dep and we just do it then.

@MrSlimeDiamond
Copy link

See #3429

I haven't got an ARM64 machine up and running to test this (will have to dust off my Raspberry Pi which I think is 64 bit, but I'm hoping someone else will be able to tell me if it works before I get to that tomorrow)

This might not work, or it might not be the best way to do this...

If someone wants to test this, give this a go - spongevanilla-1.16.5-8.0.0-RC0-universal.jar.zip

The provided link works perfectly fine for me on my ARM machine!

@dualspiral dualspiral merged commit 5953a55 into api-8 Jun 17, 2021
@dualspiral dualspiral deleted the api8/jansi-on-arm64 branch June 17, 2021 09:04
@MrSlimeDiamond
Copy link

You should probably do this for the api-9 branch too.

@dualspiral
Copy link
Contributor Author

It'll get done when someone next does a merge on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants