Fix incorrect use of display slot indexes, support getting sidebar display slot by NamedTeamColor #3405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dualspiral
added
status: input wanted
system: scoreboard
version: 1.16 (u)
This was referenced May 10, 2021
dualspiral
force-pushed
the
api8/display-slots
branch
2 times, most recently
from
1517afb
to
3d7d1e2
Compare
dualspiral
force-pushed
the
api8/display-slots
branch
from
3d7d1e2
to
25435a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpongeAPI | Sponge
This superscedes #3283 (thanks to @thibaulthenry for the initial commit!)
This adds a mapping of
ChatFormatting->SpongeDisplaySlotfor use in thefindByTeamColormethod in the API PR. I don't know if the map itself would be better in Constants as it contains registry references, happy to transplant that if we decide it's better there.