launch: More robust plugin classpath and manifest handling #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corrects builtin plugin detection in situations where the SpongeVanilla jar is not the first in the classpath, and properly allows gathering enumerations of resources. ModLauncher has been bumped, and cached manifests are now passed to the ModLauncher manifest finder.
zml2008
force-pushed
the
api8/classpath-resource-hijinks
branch
from
efdc773
to
ec1ed7a
Compare
zml2008
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects builtin plugin detection in situations where the
SpongeVanilla jar is not the first in the classpath, and properly allows
gathering enumerations of resources.