Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max-chunk-lifetime setting used by chunk gc (#3167) - fixed #3206

Merged

Conversation

PolyacovYury
Copy link
Contributor

Fixed a bug in my previous edition of this PR.

If the chunk is not queued for unload, and the max-lifetime setting is disabled - the chunk gets saved to disk. Every tick.
That else if should look like else if (max-lifetime <= 0 || !delay_expired || !isDirty) {continue;}.

Now that else if looks like it should've. :)
(If only GitHub allowed to reopen merged pull-requests by reverting it's merge commit or something...)

@thibaulthenry
Copy link
Contributor

As far as I can test, the server does not crash anymore as it used to in your previous commit.

@ImMorpheus ImMorpheus added the version: 1.12 (u) API: 7 (unsupported since May 21st 2021) label Nov 28, 2020
…- fixed

- mostly useful for those who need to disable full auto-saves controlled by auto-save-interval
- spreads out server load induced by chunk saving
- allows to periodically save chunks kept active by players for a long time
@dualspiral dualspiral merged commit a0a5428 into SpongePowered:stable-7 Dec 21, 2020
@PolyacovYury PolyacovYury deleted the add/max-chunk-lifetime branch December 21, 2020 17:02
PolyacovYury added a commit to PolyacovYury/SpongeCommon that referenced this pull request Jan 14, 2021
Zidane added a commit that referenced this pull request Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version: 1.12 (u) API: 7 (unsupported since May 21st 2021)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants