Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early configuration #3121

Merged
merged 4 commits into from
Aug 23, 2020
Merged

Conversation

zml2008
Copy link
Member

@zml2008 zml2008 commented Aug 22, 2020

Common configurations now have full access to the PluginEnvironment, and are put into an isolated source set to make sure they don't accidentally access game classes.

lots of file moves in here, sorry :(

@zml2008 zml2008 force-pushed the api8/isolated-config branch 3 times, most recently from 91a184c to 0672b7d Compare August 22, 2020 22:46
Copy link
Member

@gabizou gabizou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm debating on the package but as long as the sourceSet is good, looks good to me.

@gabizou gabizou merged commit 6b013da into SpongePowered:api-8 Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants