Reorganize config, make it work in mixin plugins #3090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zidane
reviewed
Jul 24, 2020
src/main/java/org/spongepowered/common/config/common/CommonConfig.java
Outdated
Show resolved
Hide resolved
Zidane
reviewed
Jul 24, 2020
src/main/java/org/spongepowered/common/world/SpongeWorldArchetypeBuilder.java
Outdated
Show resolved
Hide resolved
zml2008
force-pushed
the
api8/config-restructure
branch
from
5dfd08f
to
d51e9c2
Compare
A bunch of rearrangement to better sort out which options are available per-world, and which options are global only. Adds a usable versioning system.
zml2008
force-pushed
the
api8/config-restructure
branch
from
d51e9c2
to
18aa062
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of rearrangement to better sort out which options are available
per-world, and which options are global only.
Adds a usable versioning system.
Configuration actually saves.
Per-dimension type configurations are gone
Still TODO (but for a future PR):