Merge pull request #3579 from Lignium/fix/update-lighting-flag

Disable lighting updates when using BlockChangeFlags#NONE
SpongePowered · Jan 9, 2022 · 58fe5c2 · 58fe5c2
2 parents b753605 + 79d5a18
commit 58fe5c2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/main/java/org/spongepowered/common/util/Constants.java b/src/main/java/org/spongepowered/common/util/Constants.java
@@ -998,6 +998,7 @@ public static final class BlockChangeFlags {
             | Constants.BlockChangeFlags.DENY_NEIGHBOR_SHAPE_UPDATE
             | Constants.BlockChangeFlags.NEIGHBOR_DROPS
             | Constants.BlockChangeFlags.PATHFINDING_UPDATES
+            | Constants.BlockChangeFlags.LIGHTING_UPDATES
             ;
 
 

diff --git a/src/test/java/org/spongepowered/common/event/tracking/BlockChangeFlagManagerTest.java b/src/test/java/org/spongepowered/common/event/tracking/BlockChangeFlagManagerTest.java
@@ -86,7 +86,7 @@ void verifyNoneFlag() {
         assertFalse(none.updateNeighboringShapes());
         assertFalse(none.neighborDropsAllowed());
         assertFalse(none.movingBlocks());
-        assertTrue(none.updateLighting());
+        assertFalse(none.updateLighting());
         assertFalse(none.performBlockPhysics());
         assertFalse(none.notifyPathfinding());
     }
@@ -299,4 +299,4 @@ void verifyNestedNeighborPhysics() {
     }
 
 
-}
+}