Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http_build_query in OTP class #215

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

Spomky
Copy link
Member

@Spomky Spomky commented Apr 15, 2024

The change fixes a syntax issue with http_build_query in OTP class. Specifically, incorrect usage of 'arg_separator' as a keyword argument results in an error. Replaced that incorrect usage with the appropriate way of using this function, improving the reliability and correctness of building the query string.

Target branch:
Resolves issue #

  • It is a Bug fix
  • It is a New feature
  • Breaks BC
  • Includes Deprecations

The change fixes a syntax issue with http_build_query in OTP class. Specifically, incorrect usage of 'arg_separator' as a keyword argument results in an error. Replaced that incorrect usage with the appropriate way of using this function, improving the reliability and correctness of building the query string.
@Spomky Spomky added the DX label Apr 15, 2024
@Spomky Spomky added this to the 11.2.2 milestone Apr 15, 2024
@Spomky Spomky self-assigned this Apr 15, 2024
@Spomky Spomky merged commit b737d1c into 11.2.x Apr 15, 2024
13 checks passed
@Spomky Spomky deleted the cs/remove-named-argument branch April 15, 2024 07:35
Spomky added a commit that referenced this pull request Apr 15, 2024
The change fixes a syntax issue with http_build_query in OTP class. Specifically, incorrect usage of 'arg_separator' as a keyword argument results in an error. Replaced that incorrect usage with the appropriate way of using this function, improving the reliability and correctness of building the query string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant