Leeway #152
Merged
Leeway #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Spomky
commented
Feb 15, 2022
Spomky
commented
| Q | A |
|---|---|
| Branch? | v11 |
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #144 |
| License | MIT |
| Tests added | |
| Doc PR |
Closed
Closed
|
It's your code and decision, but the behavior change should really have been mentioned in the v10 to v11 upgrade notes. It's not a literal break because of an api/syntax change, but it's a more subtle, hard to detect behavior change that everybody should think about when upgrading. Projects cannot be compatible with both v10 and v11 at once without feature detection or having a leaking abstraction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.