Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task manager #150

Merged
merged 7 commits into from
Sep 23, 2015
Merged

Add task manager #150

merged 7 commits into from
Sep 23, 2015

Conversation

Gjum
Copy link
Member

@Gjum Gjum commented Sep 22, 2015

Also fix some tests on the way.

This is the beginnings of #147.

@Gjum
Copy link
Member Author

Gjum commented Sep 22, 2015

There was a discussion if this belongs into core. I think this is not required to run the client, but rather nice to use. So I put it into helpers.

@gamingrobot
Copy link
Member

+1 for having it in core, timer is not required for the client but again is nice to use.

@Gjum Gjum added the api label Sep 22, 2015
@Gjum Gjum force-pushed the task-manager branch 2 times, most recently from 52f8a2d to 7f7b480 Compare September 22, 2015 23:06
@nickelpro
Copy link
Member

core isn't "required for client to run" nor is it "nice to have". core is where things related to Spock as an event framework go, task manager is clearly an event framework feature and belongs in core.

helpers is where we put things that implement minecraft behavior or features. Other client implementations may or may not want these minecraft features, a server or proxy will likely want none of them. That is why they are easily and categorically seperated from core

@Gjum
Copy link
Member Author

Gjum commented Sep 22, 2015

OK, moving to core then.

@Gjum Gjum force-pushed the task-manager branch 4 times, most recently from 6474b06 to 2678aa9 Compare September 22, 2015 23:43
gamingrobot added a commit that referenced this pull request Sep 23, 2015
@gamingrobot gamingrobot merged commit 6a1603e into SpockBotMC:master Sep 23, 2015
@Gjum Gjum deleted the task-manager branch October 6, 2015 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants