Solve thread safety problems in Plugin, BungeeSecurityManager, and PluginManager #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A248
force-pushed
the
thread-safety
branch
2 times, most recently
from
c48e08d to
efe265c
Compare
|
sugesting to remove the formatter from pr title ;) |
A248
changed the title
|
@linsaftw responding here instead of the issue because this is the appropriate place. It would not be a good idea to move to method based synchronized. Double checked lock is a popular pattern too. |
aikar
suggested changes
Sep 4, 2020
api/src/main/java/net/md_5/bungee/api/plugin/PluginManager.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all 3 issues elaborated in #2932 .