New group rounded feature and small color fix control themes #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spiderpig86
requested changes
Nov 14, 2020
src/ext/tags.scss
Outdated
| border-radius: 0; | ||
| &.group-tags { | ||
| /* Round first and last tag in the grouped tags */ | ||
| &.group-rounded { |
There was a problem hiding this comment.
To try to stick to BEM naming conventions moving forward, we should name this group-tags--rounded.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| } | ||
|
|
||
| &:last-child { | ||
| border-radius: 0 290486px 290486px 0; |
There was a problem hiding this comment.
Shorthands of length 4 are not allowed. Value was 0 290486px 290486px 0
| // Round first and last tag in the grouped tags | ||
| &--rounded .tag { | ||
| &:first-child { | ||
| border-radius: 290486px 0 0 290486px; |
There was a problem hiding this comment.
Shorthands of length 4 are not allowed. Value was 290486px 0 0 290486px
| } | ||
|
|
||
| &:last-child { | ||
| border-radius: 0 0.25rem 0.25rem 0; |
There was a problem hiding this comment.
Shorthands of length 4 are not allowed. Value was 0 0.25rem 0.25rem 0
| &:not(:first-child):not(:last-child) { | ||
| border-radius: 0; | ||
| &:first-child { | ||
| border-radius: 0.25rem 0 0 0.25rem; |
There was a problem hiding this comment.
Shorthands of length 4 are not allowed. Value was 0.25rem 0 0 0.25rem
| &.group-tags { | ||
| .tag, | ||
| &--rounded .tag { | ||
| margin-right: 0 !important; |
| @@ -151,19 +151,33 @@ | |||
| } | |||
|
|
|||
| /* Used for grouping tags together */ | |||
| &.group-tags .tag { | |||
| margin-right: 0 !important; | |||
| &.group-tags { | |||
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sorry for so much PR's :D
I've added a common use case for actual rounding group tags. I think it should be pretty useful for some use cases. Furthermore, there are rounded tags so why not having grouped rounded tags ;)
In addition, I've added the primary color to the control themes. This fix resolved that primary colored closing tags are not clickable.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
You can see the result of the new rounded grouping tags in the image below:
