Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The italics class is not working #192

Closed
zemian opened this issue Aug 18, 2023 · 4 comments
Closed

The italics class is not working #192

zemian opened this issue Aug 18, 2023 · 4 comments

Comments

@zemian
Copy link

zemian commented Aug 18, 2023

The "Italics" example under https://www.cirrus-ui.com/fonts/text-elements does not work. I tried it on my own page and it is not working either:

<h5>Italics</h5>
<p class="italics">The quick brown fox jumps over the lazy dog.</p>
@Spiderpig86
Copy link
Owner

Ack will take a look

@Spiderpig86
Copy link
Owner

Looks like this class was removed in version 0.6.0. I think the decision was that we can just use <i> to achieve the same effect.

@zemian
Copy link
Author

zemian commented Aug 20, 2023

Thanks for the update. I did notice there are few other examples is the same such as <b> etc. But I personally prefer to be to add CSS styling rather than adding extra tag to change text styling. What's the benefit of using explicit <i>?

@Spiderpig86
Copy link
Owner

After reviewing solutions offered today, seems like a class that can style text as italicized has its benefits. I will be adding this into 0.7.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants