Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled Button bug #117

Closed
332lfgb6 opened this issue Jun 2, 2022 · 2 comments
Closed

Disabled Button bug #117

332lfgb6 opened this issue Jun 2, 2022 · 2 comments
Labels
pending release This issue has been looked at and resolved in code. It is now pending the next release.

Comments

@332lfgb6
Copy link

332lfgb6 commented Jun 2, 2022

The documentation states that div buttons are not supported, but I found that the buttons created by the A tag are not supported either
image
image
image

<button class="btn-primary" disabled>Button</button>
    <div class="btn btn-primary" disabled>Button</div>
    <input class="btn-primary" type="submit" value="Submit" disabled />
    <a href="https://www.bing.com/" class="btn btn-primary" disabled>Button</a>
@Spiderpig86
Copy link
Owner

Thanks for the bug report! I will take a look at this soon.

Spiderpig86 added a commit that referenced this issue Jun 6, 2022
… does not exist in divs and anchor tags for div and anchor tag based buttons #117
@Spiderpig86
Copy link
Owner

I took a look to see why the disabled attribute doesn't work for the a or div tags. This is because the disabled attribute is not supported for those tags.

As an alternative, I added a btn--disabled class to simulate the disabled state for a and div tags.

@Spiderpig86 Spiderpig86 added the pending release This issue has been looked at and resolved in code. It is now pending the next release. label Jul 14, 2022
@332lfgb6 332lfgb6 closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending release This issue has been looked at and resolved in code. It is now pending the next release.
Projects
None yet
Development

No branches or pull requests

2 participants