Fix issue with master pop in some cases #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix_app_master_pop_limits Conflicts: unittests/model_tests/neuron/test_synaptic_manager.py
|
This fix looks fine to me, and it passes tests, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an issue where it was possible to trigger the error check on the master pop table n_neurons. The case is triggered by a pre-vertex with a splitting of atoms something like the following (a, a, a, b) where a > 2047 but b < 2047. The check was being done on b but should have been done on a. This fixes that, and adds a test to check it works, as well as adding a test to check for the maximum number of cores case.