Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_specification_loaded to turn off requires data spec / reset #287

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Oct 30, 2024

This pr changes how requires_data_generation is used.

Master

Things that turn requires_data_generation on:

  • setup
  • hard reset
  • View.set_requires_data_generation()
    -- Called by vertex if synapse_dynamics.changes_during_run
  • View.set_requires_mapping
    -- called by anything that adds to the graph

Things that turned requires_data_generation

  • Finish_run

CHANGE

data_specification_loaded to turn requires_data_generation off
writer.set_requires_data_generation() (which can be called during run)

USAGE

If we allow timed runs to be stopped this allows requires_data_generation to be turned on in a way that is kept when Finish_run is called.

REQIORES

SpiNNakerManchester/SpiNNFrontEndCommon#1227

  • requires checking get_requires_data_generation if in a second non reset run
  • calling data_specification_loaded after loading / reloading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant