View holds requires #193
Merged
View holds requires #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the flags requires_data_generation and requires_mapping where held in many places (vertices, partitions ect) yet if even a single one was True the Mapping or Data Generation has to be redone.
Then all the flags had to be reset.
Instead there is now a single flag for each held in the View.
They can be set to True using the View
Are automatically set back to False at the end of a run.
The flags are True before the first run so will be true if is_ran_ever() is False
vertices_or_edges_added is now part of requires_mapping
AbstractChangableAfterRun no longer needed to identify what may hold these flags
mark_no_changes has been removed or for Population replaced with _reset_has_read_neuron_parameters_this_run
Must be done at the same time as:
SpiNNakerManchester/PACMAN#462
SpiNNakerManchester/SpiNNFrontEndCommon#973
SpiNNakerManchester/sPyNNaker#1217
SpiNNakerManchester/SpiNNGym#49
tested by SpiNNakerManchester/IntegrationTests#133