-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log all but string and char as hex #100
base: master
Are you sure you want to change the base?
Conversation
As I mentioned to @Christian-B and @dkfellows, I don't think that there is a need to get rid of 'io_printf()' and the ability to print values directly to 'IO_BUF'. 'io_printf()' is quite stable and requires little or no maintenance. If we got it right (big if), the linker will not link in any function that is not called, thus 'io_printf()' will not be a part of the executable file if it is not used in the application. The user can choose to use it or not, depending on their needs and the size of their executable. The case may be that the 'logging' infrastructure uses 'io_printf()'. In this case, 'logging' should stop using 'io_printf()' and use a 'hex-based' trimmed-down version, as implemented in this pull request. In this case, 'io_printf()' would not be linked in and the executable would actually benefit from the size reduction, but users like me would still have the option of using 'io_printf()' and read 'IO_BUF' directly, without the need to consult the dictionary. |
Pull Request Test Coverage Report for Build 924
💛 - Coveralls |
Do not merge until SpiNNakerManchester/SpiNNakerGraphFrontEnd#125 is Green!
Note: @oliverrhodes and @lplana would be against the complete removal of the ability to print values directly to iobuf during debugging. He is mainly interested in ints and accums. He does not mind if the abilty to format these values is removed.
I would not recommend merging this until.