Send log messages to the database #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkfellows
reviewed
May 13, 2022
|
Is what is being logged controlled by the general logging level? I ask because logging stuff at |
dkfellows
reviewed
May 13, 2022
Currently yes it does . because I had not considered that. An issue is that in FormatAdapter.log has self.isEnabledFor(level) even for level 10 (debug) |
|
If SpiNNakerManchester/SpiNNUtils#177 is approved it will be easy to only write to database if the message is of interest. |
rowleya
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
send all log messages to the provenance databse.
Must be done at the same time as:
SpiNNakerManchester/SpiNNUtils#174
This includes safety code if the database is locked.
Tested by SpiNNakerManchester/IntegrationTests#137